http://www.itwriting.com/phorum/list.php?3 EN Tue, 22 Apr 2003 01:50:52 +0100 Tue, 22 Apr 2003 01:50:52 +0100 HtmlEditor Phorum 5.1.25 60 http://www.itwriting.com/phorum/read.php?3,544,551#msg-551 James Hancock
Yes, it throws the error on the marshal.getdispatch... line.

Yes, I copied it in and overwrote the CleanupControl function in the htmleditor.cs file.

Keep up the good work!]]> HtmlEditor http://www.itwriting.com/phorum/read.php?3,544,551#msg-551 Tue, 22 Apr 2003 01:50:52 +0100 http://www.itwriting.com/phorum/read.php?3,544,550#msg-550 Tim Anderson
Having said that, I've changed the code a bit because there are circumstances when CleanupControl doesn't get called. I am on the right lines I think. To demo the issue, I've appended the results from the sample app I did to test grin's memory issue. The app calls showdialog in a loop, using a form on which there is an htmlEditor. The form loads a document and then closes. The loop runs up to 1000.

Note that if there is no event handler for HtmlEvent, the results are like the 2nd table, even with the "old" htmlEditor:

Before change
Left column - number of iterations
Right column - memory in bytes reported by GC.GetTotalMemory

0 66112 (before showing htmlEditor at all)
100 265672
200 410292
300 563096
400 715632
500 868208
600 1020720
700 1173184
800 1325648
900 1478308
1000 1632392


After change
0 66112 (before showing htmlEditor at all)
100 214668
200 206488
300 206536
400 206568
500 206648
600 206728
700 206808
800 206888
900 206968
1000 207048]]> HtmlEditor http://www.itwriting.com/phorum/read.php?3,544,550#msg-550 Mon, 21 Apr 2003 23:22:37 +0100 http://www.itwriting.com/phorum/read.php?3,544,548#msg-548 James Hancock
Commenting it out fixes it again.]]> HtmlEditor http://www.itwriting.com/phorum/read.php?3,544,548#msg-548 Mon, 21 Apr 2003 20:16:06 +0100 http://www.itwriting.com/phorum/read.php?3,544,544#msg-544 Tim Anderson
The reason is that setting the control as the event handler for COM events (in SetHTMLEvents method, HtmlEditor.cs) creates a COM reference that never gets released.

The following amended CleanupControl method seems to fix the problem, let me know of any problems.

public void CleanupControl()
{
if (IsCreated)
{
if (cookie != -1)
{
icp.Unadvise(cookie);
cookie = -1;
}

//new code here to release COM reference to control
if (m_htmldoc != null)
{
IntPtr ptr = Marshal.GetIDispatchForObject(this);
int i = Marshal.Release(ptr);
while (i > 0)
{
i = Marshal.Release(ptr);
}
}

site.CloseDocument();
site.Dispose();
site = null;
this.m_htmldoc = null;
}
}]]> HtmlEditor http://www.itwriting.com/phorum/read.php?3,544,544#msg-544 Mon, 21 Apr 2003 18:10:16 +0100